Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

application-service update #3852

Merged
merged 4 commits into from
Jun 10, 2024
Merged

application-service update #3852

merged 4 commits into from
Jun 10, 2024

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Jun 6, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested review from kim-tsao and yangcao77 June 6, 2024 09:00
johnmcollier
johnmcollier approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier
Copy link
Member

/retest

@johnmcollier johnmcollier reopened this Jun 10, 2024
@johnmcollier
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit ac97db0 into main Jun 10, 2024
7 of 8 checks passed
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2024

@rh-tap-build-team[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests ffbcf12 link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmcollier johnmcollier johnmcollier approved these changes

@kim-tsao kim-tsao Awaiting requested review from kim-tsao

@yangcao77 yangcao77 Awaiting requested review from yangcao77

Assignees

@johnmcollier johnmcollier

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnmcollier